[Mod_gzip] mod_gzip and strange vary headers
mod_gzip@lists.over.net
mod_gzip@lists.over.net
Tue, 23 Mar 2004 14:06:45 +0100
Dies ist eine mehrteilige Nachricht im MIME-Format.
--=_alternative 00480BF6C1256E60_=
Content-Type: text/plain; charset="US-ASCII"
Hi Alpheus,
> for(i=0;i<cfg->imap_total_entries;i++) {
> if(cfg->imap[i].type == MOD_GZIP_IMAP_ISREQHEADER) {
> mod_gzip_strncpy(name,cfg->imap[i].name,strstr(cfg->imap[i].name,":") -
cfg->imap[i].name - 1);
> *((const char **)ap_push_array(ary)) = ap_pstrdup(p,name);
> }
meanwhile Christian Kruse has had a look at this section.
A summary of his mail would likely be:
1. Yes, this code section contains the error causing the broken "Vary:"
headers.
2. The actual problem lies in the "mod_gzip_strncpy()" function which
is fast and simple but unusable for the case we have here.
3. Christian Kruse has already fixed this in the CVS version.
So if you download the source code from
http://cvs.sourceforge.net/viewcvs.py/mod-gzip/mod-gzip13x/
and recompile then the problem should be gone.
We should probably publish a new official version of mod_gzip soon...
Regards, Michael
--=_alternative 00480BF6C1256E60_=
Content-Type: text/html; charset="US-ASCII"
<br><font size=2 color=red face="sans-serif"><b>Hi Alpheus,</b></font><font size=3>
</font>
<br>
<br><font size=2 color=red face="sans-serif"><b>></b></font><font size=2 color=#800000 face="sans-serif"><b>
for(i=0;i<cfg->imap_total_entries;i++)
{</b></font><font size=3> </font><font size=2 color=#800000 face="sans-serif"><b><br>
</b></font><font size=2 color=red face="sans-serif"><b>></b></font><font size=2 color=#800000 face="sans-serif"><b>
if(cfg->imap[i].type == MOD_GZIP_IMAP_ISREQHEADER)
{</b></font><font size=3> </font><font size=2 color=#800000 face="sans-serif"><b><br>
</b></font><font size=2 color=red face="sans-serif"><b>></b></font><font size=2 color=#800000 face="sans-serif"><b>
mod_gzip_strncpy(name,cfg->imap[i].name,strstr(cfg->imap[i].name,":")
- cfg->imap[i].name - 1);</b></font><font size=3> </font><font size=2 color=#800000 face="sans-serif"><b><br>
</b></font><font size=2 color=red face="sans-serif"><b>></b></font><font size=2 color=#800000 face="sans-serif"><b>
*((const char **)ap_push_array(ary))
= ap_pstrdup(p,name);</b></font><font size=3> </font><font size=2 color=#800000 face="sans-serif"><b><br>
</b></font><font size=2 color=red face="sans-serif"><b>></b></font><font size=2 color=#800000 face="sans-serif"><b>
}</b></font><font size=3> </font><font size=2 color=#800000 face="sans-serif"><b><br>
</b></font>
<br><font size=2 color=red face="sans-serif"><b>meanwhile Christian Kruse
has had a look at this section.</b></font>
<br>
<br><font size=2 color=red face="sans-serif"><b>A summary of his mail would
likely be:</b></font>
<br>
<br><font size=2 color=red face="sans-serif"><b>1. Yes, this code section
contains the error causing the broken "Vary:" headers.</b></font>
<br><font size=2 color=red face="sans-serif"><b>2. The actual problem lies
in the "mod_gzip_strncpy()" function which</b></font>
<br><font size=2 color=red face="sans-serif"><b> is fast and
simple but unusable for the case we have here.</b></font>
<br><font size=2 color=red face="sans-serif"><b>3. Christian Kruse has
already fixed this in the CVS version.</b></font>
<br>
<br><font size=2 color=red face="sans-serif"><b>So if you download the
source code from</b></font>
<br><font size=2 color=red face="sans-serif"><b>
http://cvs.sourceforge.net/viewcvs.py/mod-gzip/mod-gzip13x/</b></font>
<br><font size=2 color=red face="sans-serif"><b>and recompile then the
problem should be gone.</b></font>
<br>
<br><font size=2 color=red face="sans-serif"><b>We should probably publish
a new official version of mod_gzip soon...</b></font>
<br><font size=2 color=red face="sans-serif"><b><br>
Regards, Michael</b></font>
--=_alternative 00480BF6C1256E60_=--